Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F24/trinity/update-login-page #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trinity-y
Copy link
Contributor

Notion ticket link

Update Login Page Functionality

Implementation description

Refactored login page a bit, added (temporary) loading/error modals, and added redirect to create password page.
sorry for the horrible gif quality again
Successful link:
3159cab1-2341-4440-b1e9-406c2a66e775

Invalid/expired link:
b0291dd3-5472-4b7b-82e9-42634f9f177f

Steps to test

Test successful redirect

  1. Make sure you are logged out by deleting the 'authenticated user' from local storage
  2. Ensure your status is 'Inactive' in the user database
  3. Send yourself an invite using Postman (auth/invite-user)
  4. Open email link
  5. Should redirect you to create password page

Test expired link

  1. Log out / ensure your status is inactive if you reset your password in the last test
  2. Send yourself another invite
  3. Open the old invite link
  4. An error message should be displayed

Test default behaviour of login page

  1. Log out
  2. Visit home page, and it should redirect you to the default login page

What should reviewers focus on?

  • handling of error/loading./default status

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@trinity-y trinity-y marked this pull request as ready for review November 29, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant