Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create login frontend page #53

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Create login frontend page #53

wants to merge 12 commits into from

Conversation

aliicezhao
Copy link

Notion ticket link

Login Page

Implementation description

  • Modified the Login to now display an email and password field, with validation
  • Uses Redirect on success to go to pets
  • If viewed on a phone in landscape, it becomes scrollable

Steps to test

  1. Go to localhost:3000/login, make sure data is cleared
  2. Both fields should throw error if invalid/empty field
  3. On success, should redirect to /pets

What should reviewers focus on?

  • Logging in and redirectly correctly
  • Throwing errors correctly
  • Any coding style/visual things that look off
  • Unlimited attempts at logging in?

Checklist

  • [ x] My PR name is descriptive and in imperative tense
  • [ x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • [ x] I have run the appropriate linter(s)
  • [ x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Scrrenshots

Screenshot 2024-11-27 at 12 21 10 AM Screenshot 2024-11-27 at 12 21 31 AM Screenshot 2024-11-27 at 12 21 52 AM Screenshot 2024-11-27 at 12 22 18 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants