-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S24/daniel/create password page #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! love the different components you made to make the code reusable.
Just a few issues that I found.
i did this in my branch by the way so no need to change this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, nice work.
The logo for the humane society does look a little blurry though, in the future we could probably ask the design team to send an SVG to minimize image compression on the page. Would be useful for the rest of the pages as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me!
if you tested the functionality, it's good to merge
Oh there's some linter errors, can you run the linter script? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. nice work!
86f9f6c
to
c56e80f
Compare
Notion ticket link
Set New Password Page
Implementation description
Steps to test
What should reviewers focus on?
Checklist
Mobile:
Tablet: