Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S24/daniel/create password page #47

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

MinIcecream
Copy link
Contributor

@MinIcecream MinIcecream commented Nov 9, 2024

Notion ticket link

Set New Password Page

Implementation description

  • Made the CreatePasswordPage which displays the user's email and two password fields, with validation.
  • If viewed on a phone in landscape, it becomes scrollable
  • Created responsive components for common components.
  • Changing password in create password page changes your password. Next time you log in, the updated password is used.

Steps to test

  1. Go to localhost:3000/create-password
  2. Password fields should throw errors if they don't match or if they're less than 8 characters. Otherwise, it opens the confirmation modal.

What should reviewers focus on?

  • Should the route be a PrivateRoute with allowedRoles={AuthConstants.ALL_ROLES}?
  • Should I add any other validators? Also, is there a better way I should implement form validation?
  • Any coding style/visual things that look off
  • Is there a better way to apply different styles based on device orientation?

Checklist

  • [X ] My PR name is descriptive and in imperative tense
  • [ X] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • [ X] I have run the appropriate linter(s)
  • [ X] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Mobile:

image image image

Tablet:

image image

Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! love the different components you made to make the code reusable.

Just a few issues that I found.

@trinity-y
Copy link
Contributor

Should the route be a PrivateRoute with allowedRoles={AuthConstants.ALL_ROLES}?

i did this in my branch by the way so no need to change this 🙏

Copy link
Contributor

@JustinScitech JustinScitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, nice work.

The logo for the humane society does look a little blurry though, in the future we could probably ask the design team to send an SVG to minimize image compression on the page. Would be useful for the rest of the pages as well.

@MinIcecream MinIcecream changed the title S24/daniel/create password frontend S24/daniel/create password page Nov 26, 2024
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me!

if you tested the functionality, it's good to merge

@jerry-cheng5
Copy link
Contributor

Oh there's some linter errors, can you run the linter script?

laks0407

This comment was marked as outdated.

Copy link
Contributor

@laks0407 laks0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. nice work!

@MinIcecream MinIcecream force-pushed the S24/daniel/create-password-frontend branch from 86f9f6c to c56e80f Compare November 29, 2024 00:23
@MinIcecream MinIcecream added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 9bea1d0 Nov 29, 2024
1 check passed
@MinIcecream MinIcecream deleted the S24/daniel/create-password-frontend branch November 29, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants