Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form 6251 Part III #1092

Open
philiplantz opened this issue Apr 7, 2022 · 6 comments · Fixed by #1097
Open

Form 6251 Part III #1092

philiplantz opened this issue Apr 7, 2022 · 6 comments · Fixed by #1097

Comments

@philiplantz
Copy link

philiplantz commented Apr 7, 2022

I observed two problems in this form.

line 14: Should be Schedule D line 19. Instead it is set to Schedule D line 14.
line 15: If Schedule D Tax Worksheet is not used, line 15 should be equal to line 13. Instead it is 0.
line 33: Should be line 22 minus line 32. Instead it calculates the sum.

@philiplantz
Copy link
Author

Also Form 6251 sequence number is wrong.
F6251.ts line 13 should be: sequenceIndex = 32

@zakpatterson
Copy link
Collaborator

I worked to fix this today, see the PR: #1097

Also if you would like to review and approve the fix, that would be appreciated. The PR code is deployed as a preview: https://deploy-preview-1097--ustaxes.netlify.app/start

Note you can save your data from ustaxes.org or however you're running the code, and then load it in the preview, by clicking the settings icon in the menu on the left.

image

image

@philiplantz
Copy link
Author

Lines 14 and 15 seem to be fixed.

Line 30 is blank.
Instead of l30 = Math.min(0, l24, l29)
it should be l30 = Math.min(l24, l29)

Line 38 should be l18 + l31 + l34 + l37. Instead it is l17 + l31 + l34 + l37.

@philiplantz
Copy link
Author

Thanks for the nice instructions on how to test this.

One question about testing: once Form 6251 is working correctly with my inputs, my AMT will be 0, so the form won't be included in the PDF. Is there a way from the UI to see what the form looks like even when it won't be filed because the bottom line is 0?

thegrims pushed a commit that referenced this issue Apr 9, 2022
* Simplify qual div worksheet

* Rewrite AMT 6251 part 3

Add stub Schedule D Tax Worksheet to fix references

* Fix two lingering errors per review
@philiplantz
Copy link
Author

All the problems I encountered are now fixed.

With certain values for income and deductions, form 6251 is generated even though AMT is zero.
With other (similar) values, form 6251 is not generated (which I assume is correct behavior).

@zakpatterson zakpatterson reopened this Apr 11, 2022
@zakpatterson
Copy link
Collaborator

Reopening to track when Amt should be generated.

One question about testing: once Form 6251 is working correctly with my inputs, my AMT will be 0, so the form won't be included in the PDF. Is there a way from the UI to see what the form looks like even when it won't be filed because the bottom line is 0?

This was a great idea, sorry I missed it since this issue was closed automatically.

I think we need some way to inspect any such form. We are planning to show more feedback from the PDFs as users input data. So this would be a good thing to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants