-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debugging hint to repl help #1994
base: main
Are you sure you want to change the base?
Conversation
Hmm, yes, the discoverablity of the debugger is low, which was a bit intentional, as it has some strange behavior we're not completely happy with. But in many ways, it's nice. However, maybe we should do this change in rascal-language-server, as that's the only place where we support this command. We've extended the What do you think @jurgenvinju ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
=======================================
Coverage 49% 49%
- Complexity 6290 6304 +14
=======================================
Files 664 664
Lines 59558 59559 +1
Branches 8639 8639
=======================================
+ Hits 29428 29466 +38
+ Misses 27921 27879 -42
- Partials 2209 2214 +5 ☔ View full report in Codecov by Sentry. |
If we add it here we should make it conditional on the existence of debugging features. I do agree about the low discoversbility. Another solution would be to activate the debugger when the first breakpoint is set. |
There were quite some limitations on how to start a debug session from VS Code, especially since there is no launch/debug configuration in the project. If we start generating that for every project, it might be doable, but still, what if I have 3 REPLs open, to which one do you connect? We could also just print a message in the repl at the start of it? Like: did you know... |
That would be better than nothing, but "start of it" disappears pretty quickly. But if you mean "after all the initialization and just before user input", that sounds fine. |
Any advice on how to improve this PR? This is my REPL just now - after not debugging for several weeks...
|
@urbanfly we should move this towards usethesource/rascal-language-servers as there is where this new command is introduced in the REPL. But we should also try and change the One of the problems is, this code (the REPL) needs to be revised to migrate to jline3, you raise some good points about how this interaction can be improved, but changing the infrastructure around commands (and their relevant help messages) too much right now would be wasted effort, as much will change when switching to jline3. |
all of them that have the given module on their path. That's the way it works for the JDT as well. A breakpoint in a file informs all debugging sessions, no matter wh |
It is not easy to "discover" how to start a debugging session in VS Code.
It would be nice to describe it on this page
https://www.rascal-mpl.org/docs/GettingStarted/RunningRascal/VScode/
This Stack Overflow answer/comment is how I discovered it.