run-suite:Option to specify install director and by defualt use cwd #23
Conversation
| @@ -147,6 +153,7 @@ if __name__ == '__main__': | |||
| for filename in files: | |||
| benchmark_name = filename | |||
| benchmark_executable = os.path.realpath(filename) | |||
| print install_dir, benchmark_name, benchmark_executable, filename | |||
There was a problem hiding this comment.
Please use python3 syntax ;) print(...).
If you execute the script with python 2, this might be an explanation why some things such as the detection whether the script executes itself don't work correctly.
There was a problem hiding this comment.
I don't think it was a python version problem. The script tries to run itself if you use a different directory than sycl-bench/bin to install benchmark binaries. Try it.
There was a problem hiding this comment.
I've just made a run with python2 and it worked - so that's not the culprit. Not sure what you mean - I have my installed script and benchmark in $ROOT/cmake-build/install/bin and it works fine. Can you please describe how your setup looks like? Where do you install to?
There was a problem hiding this comment.
Try by specifying -DCMAKE_INSTALL_PREFIX=build-dir during cmake.
There was a problem hiding this comment.
Tried this, still working ;) Maybe there is a symlink or something like that in your path? Anyway, having thought about it I now believe just moving the benchmarks to a subdirectory is the most elegant solution.
|
We could also rename the script from |
|
Doesn't this only fix the issue if you don't execute the script from the install directory (that's where cmake installs it), but use another copy, e.g. from the build directory? I think this would be a rather confusing solution. |
I think this will also solve the problem. |
|
I would like to propose pr #24 as a solution. |
Hi Askel, I added an option to specify the install directory and by default it uses cwd. It will solve the problem where run-suite is running itself as a benchmark and gives the option to specify any install directory. I will remove print statements if you think this change is fine.