Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI check for REMOVE BEFORE FLIGHT #968

Open
eggrobin opened this issue Nov 15, 2024 · 0 comments
Open

Add a CI check for REMOVE BEFORE FLIGHT #968

eggrobin opened this issue Nov 15, 2024 · 0 comments
Assignees

Comments

@eggrobin
Copy link
Member

We just merged this:

// REMOVE BEFORE FLIGHT: The actual version will be greater than 0x100000.
if (ch <= 0x187FF && rCompositeVersion >= 0x100000) {
// Unicode [..] added TANGUT IDEOGRAPH-187F8..TANGUT IDEOGRAPH-187FF.
return TANGUT_BASE;
}

Might also do DO NOT SUBMIT which is standard Google practice.

(I wrote such a check a in another place year and a half ago, so this is easy.)

@eggrobin eggrobin self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant