Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK] bidi clarifications #958

Open
macchiati opened this issue Nov 22, 2024 · 0 comments
Open

[FEEDBACK] bidi clarifications #958

macchiati opened this issue Nov 22, 2024 · 0 comments
Labels
Preview-Feedback Feedback gathered during the technical preview

Comments

@macchiati
Copy link
Member

macchiati commented Nov 22, 2024

We had a discussion around the implications of bidi isolation, in formatting.md. I'm capturing some items here for post 46.1

  1. General issue. While it is clear that Default Bidi Strategy is the correct strategy in the general case, the algorithm seems to preclude various optimizations. It should make it clear that an implementation is conformant to the DBS if the bidi ordering it produces for any formatted pattern is identical to the bidi ordering produced for that pattern by the DBS.
  2. It should also make clear than an implementation may generate equivalent results for other environments. Eg, when generating HTML, it could produce bidi markdown instead of the Unicode bidi control characters. This might be covered by #formatting, but best to have it specifically called out.
  3. Details
    1. In #handling-bidirectional-text we have "Let msgdir be the directionality of the whole message," but it is not defined.
    2. In #formatting-context we have "Information on the base directionality of the message and its text tokens. This will be used by strategies for bidirectional isolation, and can be used to set the base direction of the message upon display." That sounds like it is supposed to define msgdir — or at least the connection between them needs to be clear.
    3. "Let fmt be the formatted string representation of the resolved value of exp." should be "Let fmt be the formatted string representation of exp."

A related issue: in #formatting it should make it clear that callers of implementations cannot rely on the literal text in a pattern being preserved in the formatted pattern. That is, an implementation could change the literal text, such as improving the result of {{You have an {$item} in your basket.}} based on the value of $item, eg "You have an apple in your basket." vs "You have a pear in your basket.".

@macchiati macchiati added the Preview-Feedback Feedback gathered during the technical preview label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview-Feedback Feedback gathered during the technical preview
Projects
None yet
Development

No branches or pull requests

1 participant