-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review non-integral exact number selection algorithm #675
Comments
Add:
, except in phrasing like "an average of 3.4 books per child".
…On Wed, Feb 21, 2024, 04:59 Eemeli Aro ***@***.***> wrote:
After the discussions in #621 (comment)
<#621 (comment)>
and #621 (comment)
<#621 (comment)>
as well as our live calls, we ended up leaving out an explicit definition
of numerical matching for non-integer values like 0.0 or 1.5, but the text
around this
<https://github.com/unicode-org/message-format-wg/blob/main/exploration/number-selection.md#determining-exact-literal-match>
carries three separate notes about the current solution.
After the publication of LDML 45, we should revisit this and seek to
specify the text further. We should also ensure that our solution is in
line with the existing LDML Language Plural Rules, which includes a section
on Explicit 0 and 1 rules
<https://unicode-org.github.io/cldr/ldml/tr35-numbers.html#Explicit_0_1_rules>.
In particular, there we already have:
The explicit “0” and “1” cases apply to the exact numeric values 0 and 1
respectively. These cases are typically used for plurals of items that do
not have fractional value, like books or files.
This should be accounted for in the MF2 text, and an appropriate solution
here might be to expand the current Language Plural Rules section, so that
in the MF2 text we can refer to it for exact number matching.
—
Reply to this email directly, view it on GitHub
<#675>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMEVL7FHYW6UQKPQHXLYUXVTBAVCNFSM6AAAAABDTAFIIKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DMNZQGA3TMNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I agree with having this issue. I note (as I did in the call) that exact fraction matching is a rare corner case. Plural rules work just fine with non-integer values to produce keywords (fractions, including ones like I do not agree that this is plural matching. The explicit
in favor of:
Which brings us back to fractional matching. I can imagine cases for it:
But the more common use case is to have cutoff points, like switching units or from compact to full presentation. (This is the one thing ChoiceFormat is good at):
|
These tests may be able to be re-added after resolving unicode-org#675
These tests may be able to be re-added after resolving #675
Moving this to registry, since the number functions are where this is defined. The WG consensus in 46.1 is that we're fine with integer selection being well-defined with implementations allowed to support non-integer selection. We don't want to close this issue, but we aren't going to fix it in 46.1. |
After the discussions in #621 (comment) and #621 (comment) as well as our live calls, we ended up leaving out an explicit definition of numerical matching for non-integer values like 0.0 or 1.5, but the text around this carries three separate notes about the current solution.
After the publication of LDML 45, we should revisit this and seek to specify the text further. We should also ensure that our solution is in line with the existing LDML Language Plural Rules, which includes a section on Explicit 0 and 1 rules. In particular, there we already have:
This should be accounted for in the MF2 text, and an appropriate solution here might be to expand the current Language Plural Rules section, so that in the MF2 text we can refer to it for exact number matching.
The text was updated successfully, but these errors were encountered: