Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU4X should avoid having ICU4X in its dependency tree via url crate #5871

Open
sffc opened this issue Nov 23, 2024 · 2 comments
Open

ICU4X should avoid having ICU4X in its dependency tree via url crate #5871

sffc opened this issue Nov 23, 2024 · 2 comments
Labels
C-process Component: Team processes needs-approval One or more stakeholders need to approve proposal

Comments

@sffc
Copy link
Member

sffc commented Nov 23, 2024

Currently we have the url crate in our dependency tree via icu_provider_source, which causes us to pull in multiple copies of icu4x:

icu_provider_source v2.0.0-beta1 (/usr/local/google/home/sffc/projects/icu4x/provider/source)
├── calendrical_calculations v0.1.2 
...
├── icu v2.0.0-beta1 (/usr/local/google/home/sffc/projects/icu4x/components/icu)
│   ├── icu_normalizer v2.0.0-beta1 (/usr/local/google/home/sffc/projects/icu4x/components/normalizer) (*)
...
├── ureq v2.10.1
│   ├── url v2.5.4
│   │   ├── idna v1.0.3
│   │   │   ├── idna_adapter v1.2.0
│   │   │   │   ├── icu_normalizer v1.5.0

We should try to avoid this. I think the url crate was considering making icu4x an optional feature. Alternatively, maybe we should use something other than ureq. That would still be brittle because any of our other dependencies could still choose at any time to add url back as a dependency.

@Manishearth @hsivonen

@sffc sffc added C-process Component: Team processes needs-approval One or more stakeholders need to approve proposal labels Nov 23, 2024
@sffc
Copy link
Member Author

sffc commented Nov 23, 2024

Note that this is also in our main Cargo.lock file.

[[package]]
name = "idna_adapter"
version = "1.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "daca1df1c957320b2cf139ac61e7bd64fed304c5040df000a745aa1de3b4ef71"
dependencies = [
 "icu_normalizer 1.5.0",
 "icu_properties 1.5.1",
]

@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Nov 23, 2024
@Manishearth
Copy link
Member

It's going to be really hard to do any networking without the url crate, it's basically the only thing out there.

One of the reasons there was a much higher bar to make such changes to the crate was that there's no well integrated alternative.

We're not going to be able to drop that dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-process Component: Team processes needs-approval One or more stakeholders need to approve proposal
Projects
None yet
Development

No branches or pull requests

2 participants