Segmenter constructor options/preferences normalization #5856
Labels
C-segmentation
Component: Segmentation
needs-approval
One or more stakeholders need to approve proposal
Milestone
In #3284 we decided to add a
content_locale
option to segmenter.In #5839, @zbraniecki asked some questions about the signature of the constructors.
Currently we have constructors of the following shape:
new
: singleton static data (infallible), no content locale tailoringstry_new_unstable
: dynamic data, no content locale tailoringstry_new_with_options
: static data with content locale tailoringstry_new_with_options_unstable
: dynamic data with content locale tailoringsWhich of the following should we do?
with_options
.with_options
. Keep constructor 1 as a compiled data infallible optimization.And, should we take a
LanguageIdentifier
or a preferences bag for the content locale? (Please understand the discussion in #3284 before stating an opinion on this)@zbraniecki @makotokato @aethanyc @Manishearth
The text was updated successfully, but these errors were encountered: