Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale of constructed object design #2237

Closed
sffc opened this issue Jul 24, 2022 · 5 comments
Closed

Locale of constructed object design #2237

sffc opened this issue Jul 24, 2022 · 5 comments
Assignees
Labels
A-tailoring Area: User preferences, locale extensions, tailoring C-meta Component: Relating to ICU4X as a whole duplicate This issue or pull request already exists T-docs-tests Type: Code change outside core library U-ecma402 User: ECMA-402 compatibility

Comments

@sffc
Copy link
Member

sffc commented Jul 24, 2022

Split from #173

The design doc submitted in #1237 does not appear to address one of the original questions from #173, which is what types of getters we should expose on formatters to describe what locale they represent.

CC @mihnita

@sffc sffc added T-docs-tests Type: Code change outside core library C-meta Component: Relating to ICU4X as a whole discuss Discuss at a future ICU4X-SC meeting A-tailoring Area: User preferences, locale extensions, tailoring labels Jul 24, 2022
@mihnita
Copy link
Contributor

mihnita commented Aug 1, 2022

I think that #173 mixes 2 concerns:

  1. The getters for Requested / Valid / Actual locale
  2. The first comment in Locale of constructed object & language negotiation in data loading #173 (from Zibi) about Requested / Available / Last Fallback / Resolved Locales

The second one is the one addressed by the "Design doc: locale fallback and negotiation #1237"

The first one I remember being discussed in detail in a meeting.
The various arguments are captured in an issue, or in some meeting notes.
I will search it and will link to it, if I find it.

But the gist of my argument there was that I think that "requested" is OK and possible to implement, but "valid" and " " are basically impossible (at least impossible to give something useful).

To format something we often assemble pieces from a lot of places.
Think "2-23 dollars"
Mixes in numbering formatting symbols (separators, grouping rules), digit types, translation for "dollars", plural rules, currency range format pattern.
And (if for example the requested locale was en-US) these might come from root, en, en-US, Latn (en -> likely subtags).
For dates the first day of the week / week-end come from the country, not the full locale.

Something like actual or valid would return (maybe) a map with info for each piece.
Which is (I would argue) both ugly and useless.

But this does not capture the comments other had.
I will try to find the meeting notes.

@sffc sffc added the U-ecma402 User: ECMA-402 compatibility label Feb 23, 2023
@sffc
Copy link
Member Author

sffc commented Feb 23, 2023

Note that we need to answer this question for the purposes of ECMA-402 resolvedOptions.

@sffc
Copy link
Member Author

sffc commented Jun 22, 2023

Discuss in the ICU-TC call.

@sffc sffc added the discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band label Jun 22, 2023
@sffc
Copy link
Member Author

sffc commented Feb 29, 2024

This is mostly the same as #3906

@sffc
Copy link
Member Author

sffc commented Jun 27, 2024

Closing as duplicate of #3906

@sffc sffc closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@sffc sffc added duplicate This issue or pull request already exists and removed discuss Discuss at a future ICU4X-SC meeting discuss-triaged The stakeholders for this issue have been identified and it can be discussed out-of-band labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tailoring Area: User preferences, locale extensions, tailoring C-meta Component: Relating to ICU4X as a whole duplicate This issue or pull request already exists T-docs-tests Type: Code change outside core library U-ecma402 User: ECMA-402 compatibility
Projects
None yet
Development

No branches or pull requests

2 participants