fix: import order #459
Open
fix: import order #459
+416
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sorrycc 看看这个。 |
sorrycc
reviewed
Sep 4, 2020
| } | ||
| } | ||
|
|
||
| Property(path, state) { |
There was a problem hiding this comment.
统一都在 ImportDeclaration 处理掉了
There was a problem hiding this comment.
那就是按 import 来算，而不是按使用来算，那和之前的逻辑不一样了吧，比如 import * as antd from antd, <antd.Button /> 这种逻辑还能覆盖吗？
There was a problem hiding this comment.
这种 import 在 ImportDeclaration 确实处理不到， 但是属于 MemberExpression，所以 MemberExpression 保留了
There was a problem hiding this comment.
只有 MemberExpression 不够，之前加的东西都是有场景用上的。
There was a problem hiding this comment.
我觉得解这个问题的思路应该是记录删除的 import 的位置，然后再在相应的位置加回去。
There was a problem hiding this comment.
以前的思路是找到使用的地方然后 remove -> unshift，现在 babel 提供了 replace refactor 的工具函数 replaceWithMultiple ，改掉 import 那么作用域的内的都会替换
只有 MemberExpression 不够，之前加的东西都是有场景用上的。
跑完测试感觉是没什么大问题的，可能以前的一些修改没加测试用例就不好说
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #423