Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbraco.Decimal property editor return 0 when the number does not have decimals #17655

Open
runegronkjaer opened this issue Nov 27, 2024 · 2 comments

Comments

@runegronkjaer
Copy link

runegronkjaer commented Nov 27, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.3.1

Bug summary

Umbraco.Decimal property editor return 0 when the number does not have decimals.

If I write e.g. 9.6 the .Value() will return the decimal 9.6
If I write e.g. 9 the .Value() will return the decimal 0

Specifics

I have pinpointed the issue to the static method DecimalValueConverter.ParseDecimalValue(object? source)

The problem is that object? source is an integer and that scenario is not handled.

Steps to reproduce

Just try inputting an integer number into the Umbraco.Decimal property. In my case it's on a Block in a Block List.
The Value will be 0

My Data type is set up like this. Pretty standard.
2024-11-27 12_53_54-Umbraco

Expected result / actual result

Integer numbers should just be casted to a decimal.


This item has been added to our backlog AB#46444

Copy link

Hi there @runegronkjaer!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bergmania bergmania added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Nov 27, 2024
@Zeegaan
Copy link
Member

Zeegaan commented Nov 29, 2024

I hard a hard time reproducing this, until i realized that you said you had it in a block 🙈
This actually works when not in a block, as the Model.Value() gets passed in as a string, but when in a block, it gets passed as an actual integer, and doesn't work
My setup:
image
Homepage:
image

Thanks for the detailed report, i can reproduce 🐛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants