allow typescript v5 #498
allow typescript v5 #498
Conversation
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
can we get this merged |
|
when this will be merged? |
|
so you can can use "overrides" in package.json but we decided to go another direction. This problem definitely made us question using twind since it doesn't look to be maintained anymore |
|
Hi @PatrickJS what was your solution? |
|
@kasvith my solution was to migrate off since the project isn't maintained anymore. StyleX has a tw-to-stylex https://github.com/nmn/tw-to-stylex and @nmn is happy to help 😁 |
|
Hi @PatrickJS thanks for suggestion, im using solidjs wondering whether it will work same |
|
@kasvith yup. Solidjs is fully supported with StyleX. There are two open source Vite plugins for StyleX, but you can also try using the hand rolled plugin shared in the Qwik Example. https://stylexjs.com/docs/learn/ecosystem/ Last I tried, there were issues with Solid Start though. I haven’t tried again in the last couple of months though. |
|
Hello @sastan is there any additional work required to get this change merged? Myself and others would appreciate having this issue resolved. I see we can use npm's |
You might find our contributing section about Submitting Pull Requests helpful.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Ideally, include a test that fails without this PR but passes with it.Tests
pnpm testand verify the project withpnpm checkChangesets
If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by runningpnpx changesetand following the prompts. All changesets should bepatchuntil Twind 1.0just allows typescript v5 to be used. closes #497 , didn't try it out to see if typescript v5 has any issues with this though i doubt it.