Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: subtraction followed by a variable not normalized properly #429

Closed
sibbng opened this issue Dec 28, 2022 · 3 comments · May be fixed by #430
Closed

[Bug]: subtraction followed by a variable not normalized properly #429

sibbng opened this issue Dec 28, 2022 · 3 comments · May be fixed by #430
Labels
🛑 Abandoned The issue or Pull Request will not be worked on 🐞 Bug Bug or Bug fixes

Comments

@sibbng
Copy link
Contributor

sibbng commented Dec 28, 2022 •
edited
Loading

Reproduction

https://twind.run/baton-wound-radius?result=css

Describe the bug

Hi @sastan, in tailwindlabs/tailwindcss#4147 I contributed tailwindcss to fix some arbitrary values related issues. As I mentioned in the PR, I got this regex from twind project. But it has an edge case as reported in tailwindlabs/tailwindcss#9832. I fixed this in tailwindlabs/tailwindcss#10074. But I'm not sure if my solution is ideal or not. I wanted to let you know, the same issue also exists in twind. I can make a PR if you think my solution is good enough.

Severity

annoyance

System Info

-

Additional Information

No response
@sibbng sibbng added the 🐞 Bug Bug or Bug fixes label Dec 28, 2022
@sastan
Copy link
Collaborator

sastan commented Dec 28, 2022

Thanks for the heads-up. It would be really appreciated if you could create a PR to fix this in twind as well.

@sibbng sibbng mentioned this issue Dec 30, 2022
Open
5 tasks
@ayame113
Copy link

ayame113 commented Aug 5, 2023 •
edited
Loading

Perhaps I ran into the same issue. The combination of max() and var() breaks css variables.
https://twind.run/denim-airline-vampire?result=css

@stale stale bot added the 🛑 Abandoned The issue or Pull Request will not be worked on label May 1, 2024
@stale Stale
Copy link

stale bot commented Jun 1, 2024

Hey folks. This issue hasn't received any traction for 90 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ

@stale stale bot closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🛑 Abandoned The issue or Pull Request will not be worked on 🐞 Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly normalize subtraction followed by a variable sibbng/twind
3 participants
@sastan @sibbng @ayame113