Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can v2.0.1 work well with rocksdb 0.15.0? #42

Open
ws4charlie opened this issue Apr 17, 2021 · 4 comments
Open

Can v2.0.1 work well with rocksdb 0.15.0? #42

ws4charlie opened this issue Apr 17, 2021 · 4 comments

Comments

@ws4charlie
Copy link

Hi, I am sorry to bother you guys and put my question in here which might not be the correct place. I have been looking for a Merkleized KV store for my project and this Merk looks pretty nice to me. After looking into the latest release 'v2.0.1' for a while, I noticed that the Merk is still using rocksdb 0.14.0 instead of 0.15.0, which is now being used in develop branch of Merk.

The question is that can I simply point underlying rocksdb to 0.15.0 on a fork of Merk "v2.0.1" and assume that everything will be working fine if "cargo test" pass? The reason I wanted to upgrade to rocksdb 0.15.0 was that it provides both upper_bound and lower_bound options for iterator. I appreciate it if any of you guys could help me on this. Thanks a lot.

@mappum
Copy link
Collaborator

mappum commented Apr 17, 2021

Hey @ws4charlie, thanks for your interest in merk!

As far as I know, updating to 0.15.0 shouldn't cause any issues. I'll be creating a new merk release soon including the recent work on chunk proofs and queries which will include 0.15.0. Then if you'd like to submit a PR using the upper/lower bounds that would be very much appreciated (could be rust-idiomatic, e.g. fn <R: RangeBounds<&[u8]>>range(&self, bounds: R) -> MerkIter { ... }).

@ws4charlie
Copy link
Author

Sure. I'll do it but just by simply exposing an iterator accepting customized options. I'll let you know.

@ws4charlie
Copy link
Author

ws4charlie commented Apr 19, 2021

Hi @mappum , Seems I can't push branch or create PR on Merk. Could you please check and see my revised source file mod.rs(test cases included) for range-based queries. Can you please let me know your decision for the release? Thanks a lot.

mod.rs.zip

image

image

@tylerztl
Copy link

Hey @ws4charlie, thanks for your interest in merk!

As far as I know, updating to 0.15.0 shouldn't cause any issues. I'll be creating a new merk release soon including the recent work on chunk proofs and queries which will include 0.15.0. Then if you'd like to submit a PR using the upper/lower bounds that would be very much appreciated (could be rust-idiomatic, e.g. fn <R: RangeBounds<&[u8]>>range(&self, bounds: R) -> MerkIter { ... }).

@mappum Hi, when will the new version be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants