Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound of crashing waves #813

Closed
PanderMusubi opened this issue Sep 29, 2021 · 2 comments
Closed

Add sound of crashing waves #813

PanderMusubi opened this issue Sep 29, 2021 · 2 comments
Labels
enhancement New feature or request stale

Comments

@PanderMusubi
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Add sound of crashing waves as was discussed in #534 (comment)

Describe the solution you'd like

Add waves from https://freesound.org/people/Luftrum/sounds/48412/ (after converting to MP3).

This is also used in waves.ogg in https://github.com/rafaelmardojai/blanket/tree/master/data/resources/sounds

Possibly add more sounds used in Blanket when relevant, see https://github.com/rafaelmardojai/blanket/blob/master/SOUNDS_LICENSING.md for sources and licences.

@PanderMusubi PanderMusubi added the enhancement New feature or request label Sep 29, 2021
@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented Sep 30, 2021

@PanderMusubi Currently we're using this [original source]; it is titled "Seaside" in the app. I don't think these sound effects are different, are they?

@stale stale bot added the stale label Nov 25, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants