Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with cargo build --release --locked in windows #119

Open
FotiosBistas opened this issue Oct 13, 2023 · 1 comment
Open

Building with cargo build --release --locked in windows #119

FotiosBistas opened this issue Oct 13, 2023 · 1 comment

Comments

@FotiosBistas
Copy link

FotiosBistas commented Oct 13, 2023

Hello,

I'm trying to build the workspace inside a windows environment. Inside the root directory of the project I am running cargo build --release --locked and getting this error:

error[E0432]: unresolved import `tokio::signal::unix`
 --> bitswap-monitoring-client\src\gateways.rs:7:20
  |
7 | use tokio::signal::unix::{signal, Signal, SignalKind};
  |                    ^^^^ could not find `unix` in `signal`

I assume this is a windows thing and maybe building with docker is a far better idea.

@mrd0ll4r
Copy link
Member

Hey,
yes, that only works on Unix. In theory I suppose we could add some conditional compilation that basically does

  1. If you're compiling for Unix, enable reloading of lists via signals
  2. If you're not compiling for Unix, disable that.

If you want, you can try writing a PR :) But not need.
Docker should work.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants