Pagination margin #807
Pagination margin #807
Conversation
Fixes #777
|
Sorry, I overlooked @luukdv about the negative margin on the wrapper. Unfortunately this solution won't work because the I solved it by changing the pagination breakpoint and showing less pages in the pagination by default. |
| @@ -31,7 +31,7 @@ | |||
| .prev { | |||
| float: left; | |||
|
|
|||
| @include respond-to('medium') { | |||
| @include respond-to('large') { | |||
There was a problem hiding this comment.
Generally speaking, I don't really like this solution. Just because @luukdv's theoretical proposal causes a practical issue (specifity issue in this case), I don't think this should be solved this way. I'd recommend dealing with the specifity issue.
In this case, showing pagination on screens smaller than 981px could come in handy for users.
| $context['pagination'] = Timber::get_pagination([ | ||
| 'mid_size' => 2, | ||
| 'mid_size' => 1, |
There was a problem hiding this comment.
I personally also preferred a mid_size of 2 (in most cases this looks and works better, because there are often 6-7 pages that don't need to be split up necessarily), but that's just my opinion.
|
I will close this PR since it is not a good solution for the issue. I have no better solution right now, so I will remove the issue from the milestone for this release as well. |
Fixes #777