Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Performance: menu's #740

Open
haroldangenent opened this issue Oct 17, 2016 · 3 comments
Open

Performance: menu's #740

haroldangenent opened this issue Oct 17, 2016 · 3 comments

Comments

@haroldangenent
Copy link
Member

Adding the menu's to the Twig context is about 20% of every page load. This is quite a lot, considering menu's are not highly dynamic and hardly ever change.

Menu's could be either (heavily) cached or maybe even static (i.e. a footer menu). Dynamic menu's could always be created for projects with ACF or an ACF starter or library.

For cache, invalidation has to be taken into account, although not it's as important as in #739.

@sboerrigter
Copy link
Member

I prefer caching over static menu's so our clients have some freedom to change the menu's. I am affraid we will get a lot of support tickets if clients are not able to change their (main) menu.

@haroldangenent
Copy link
Member Author

As mentioned above in the given options:

Dynamic menu's could always be created for projects with ACF or an ACF starter or library.

I'm not suggesting replacing highly dynamic menu's with static menu's.

@haroldangenent
Copy link
Member Author

We should take 'current state' for the main navigation into account. Not sure how Timber\Menu handles this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants