Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Implement touch support from toggle-navigation #564

Open
luukdv opened this issue Oct 6, 2015 · 5 comments
Open

Implement touch support from toggle-navigation #564

luukdv opened this issue Oct 6, 2015 · 5 comments

Comments

@luukdv
Copy link

luukdv commented Oct 6, 2015

Right now, we serve a mobile version of a website based on a predefined width (980). Maybe we should also do this when touch is detected? For example through adding a body class. Some landscape tablets are now faced with a dropdown menu that doesn't work intuitively/properly.

@luukdv luukdv added the proposal label Oct 6, 2015
@gewoonderrik
Copy link
Contributor

Shouldn't we just make the entire website intuitive on touch screen devices? Some things feel a bit clunky (like the menu).

Related to #544.

@sboerrigter sboerrigter added this to the 1.1.5 milestone Mar 17, 2016
@haroldangenent haroldangenent removed this from the 1.1.5 milestone Mar 17, 2016
@haroldangenent
Copy link
Member

@luukdv What's the status on this again? ngMaterial: no, ontouchstart: yes.

Or is this just about the way main navigation is handled? If so, we could rename this issue to better reflect it's scope.

@luukdv luukdv changed the title Touchscreen detection Main navigation on touchscreens May 17, 2016
@luukdv
Copy link
Author

luukdv commented Aug 4, 2016

I have a basic proof of concept in the https://github.com/trendwerk/trendpress/tree/touchscreen-menu branch. I've put all the changed/added styling in header.scss so you can see some of the problems I'm running into ('conditional' include of toggle-navigation(), padding-top overwrite on the body...). Furthermore, there's the issue of the fullwidth menu when toggling.

Do you have thoughts about this? I don't know if this the way to go, maybe we should just leave it as it was and create a solid submenu-hover library which works well on touchscreens.

@haroldangenent
Copy link
Member

haroldangenent commented Aug 4, 2016

Decided to move this to trendwerk/toggle-navigation, but needs to be implemented in the theme.

@luukdv
Copy link
Author

luukdv commented Aug 8, 2016

@luukdv luukdv closed this as completed Oct 4, 2016
@luukdv luukdv changed the title Main navigation on touchscreens Implement touch support from toggle-navigation Oct 4, 2016
@luukdv luukdv reopened this Oct 4, 2016
@luukdv luukdv removed their assignment Oct 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants