Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow service owner references #752

Open
jspdown opened this issue Sep 29, 2020 · 1 comment
Open

Shadow service owner references #752

jspdown opened this issue Sep 29, 2020 · 1 comment
Assignees
@jspdown
Labels
area/controller area/services kind/enhancement a new or improved feature.

Comments

@jspdown
Copy link
Contributor

jspdown commented Sep 29, 2020

Feature Request

Proposal

Instead of manually cleaning up shadow services in the cleanup command it would be more appropriate to create
shadow services with the controller deployment as an OwnerReference. This will delegate shadow service deletion to kubernetes garbage collector and the cleanup command could be simplified.

Workarounds

Keep using the cleanup command for removing shadow services.
@SantoDE
Copy link

SantoDE commented Oct 12, 2020

👍

@jspdown jspdown self-assigned this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jspdown jspdown

Labels
area/controller area/services kind/enhancement a new or improved feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SantoDE @jspdown