Support line ranges in :Gbrowse for commits #36
Comments
|
The basic logic for figuring out the diff line can be found in If a range is given, I'd say just use the first line of it, regardless of where the cursor is. |
odnoletkov
added a commit
to odnoletkov/vim-rhubarb
that referenced
this issue
Feb 10, 2019
Anchor format is #diff-<MD5 of path>[L|R]<line number> With L line number is relative to the --- side, with R to the +++ side. Path of the +++ side used when it exists, otherwise path of the --- side (for removals). Closes tpope#36
odnoletkov
added a commit
to odnoletkov/vim-rhubarb
that referenced
this issue
Aug 21, 2019
Anchor format is: #diff-<MD5 of path>[[L|R]<start line number>[-[L|R]<end line number>]] With L line number is relative to the '---' side, and R to the '+++' side of the diff. Path of the '+++' side used when it exists, otherwise path of the '---' side (for removals). Closes tpope#36
odnoletkov
added a commit
to odnoletkov/vim-rhubarb
that referenced
this issue
Aug 22, 2019
Anchor format is: #diff-<MD5 of path>[[L|R]<start line number>[-[L|R]<end line number>]] With L line number is relative to the '---' side, and R to the '+++' side of the diff. Path of the '+++' side used when it exists, otherwise path of the '---' side (for removals). Closes tpope#36
|
hey @odnoletkov , it seems you implemented something like this in your fork. Are you planning to integrate it into the plugin? |
|
See #37 |
|
Note the linked Fugitive PR is a prerequisite and the current bottleneck. |
odnoletkov
added a commit
to odnoletkov/vim-rhubarb
that referenced
this issue
Sep 18, 2019
Anchor format is: #diff-<MD5 of path>[[L|R]<start line number>[-[L|R]<end line number>]] With L line number is relative to the '---' side, and R to the '+++' side of the diff. Path of the '+++' side used when it exists, otherwise path of the '---' side (for removals). Closes tpope#36
odnoletkov
added a commit
to odnoletkov/vim-rhubarb
that referenced
this issue
Apr 6, 2021
Anchor format is: #diff-<SHA256 of path>[[L|R]<start line number>[-[L|R]<end line number>]] With L line number is relative to the '---' side, and R to the '+++' side of the diff. Path of the '+++' side used when it exists, otherwise path of the '---' side (for removals). Closes tpope#36
odnoletkov
added a commit
to odnoletkov/vim-rhubarb
that referenced
this issue
Apr 7, 2021
Anchor format is: #diff-<SHA256 of path>[[L|R]<start line number>[-[L|R]<end line number>]] With L line number is relative to the '---' side, and R to the '+++' side of the diff. Path of the '+++' side used when it exists, otherwise path of the '---' side (for removals). Closes tpope#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be great to have
:{range}Gbrowseworking for commit objects. Especially useful for doing code reviews.Sample URL:
Anchor format is:
with
Lline number is relative to the origin, withRto the resultCouldn't find a way to select a range in this view, for selected range can either route to the first line or to the cursor position.
As far as I understand for
commitfugitive currently doesn't provide path and line numbers, changing that should be most of the work.The text was updated successfully, but these errors were encountered: