Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimmed leading zeros for FIPS #7

Closed
johnmnelson opened this issue Jan 25, 2017 · 6 comments
Closed

Trimmed leading zeros for FIPS #7

johnmnelson opened this issue Jan 25, 2017 · 6 comments

Comments

@johnmnelson
Copy link

County FIPS are a five-digit key. The counties with a leading zero have been trimmed so that joining to another file with the full FIPS code will likely fail.

@johnmnelson
Copy link
Author

Also, thanks for doing this!

@d-alex-hughes
Copy link

Let me agree with @johnmnelson, and also clarify. In the combined_fips, states with State FIPS code in the range {01, ... , 09} are being stored as {1, ... , 9}. This is despite the reporting in your notebook printout. I think that a pretty simple flag in the write call should handle it?

@tonmcg
Copy link
Owner

tonmcg commented Jun 23, 2017

Agreed. The issue was fixed in "US_County_Level_Presidential_Results_12-16.ipynb" notebook and still only exists in the "2016_US_County_Level_Presidential_Results.ipynb". I'd like to delete that last file, but don't know whether it's used by anyone. Thoughts?

@d-alex-hughes
Copy link

I could write a quick patch to create two additional columns on the df that exists currently. (Actually I already did for the project that I'm working on.) If that works, I'll write it an make a pull request?

@tonmcg
Copy link
Owner

tonmcg commented Sep 7, 2018

@d-alex-hughes Forgive me for the delayed response. If you're still able to do that, then we can take a look at the results and accept your PR.

@tonmcg
Copy link
Owner

tonmcg commented Nov 26, 2024

This is outdated. Closing.

@tonmcg tonmcg closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants