-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwanted PHP warning for failed unserialize #1090
Comments
Hi there, thank you for taking your time to create your first issue. Please give us a bit of time to review it. |
This looks like it could be related to #1087, do you agree? |
Same root but in my case both commands |
But yes, we could close this issue as its not really relevant if the command is running but rising warnings or gets terminated after the first warning. |
I'll close this issue as @ulrichmathes suggested. |
Bug Report
Current Behavior
JsonCompatibilityConverter:53
rises PHP warningExpected behavior/output
When JsonCompatibilityConverter tries to unserialize a string and fails, there should be no warning.
There is a
try catch
block, but unserialize emits a warning instead of throwing an exception.Steps to reproduce
I think JsonCompatibilityConverterTest will rise this warning but unitTests are configured as
failOnWarning="false"
.Environment
Possible Solution
suppress the warning via
@unserialize
instead of not applyingtry catch
?Additional context
This issue is caused by the change in PHP 8.3:
The text was updated successfully, but these errors were encountered: