Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests in logs microservice #625

Open
suryajak opened this issue Nov 17, 2018 · 3 comments
Open

Fix unit tests in logs microservice #625

suryajak opened this issue Nov 17, 2018 · 3 comments

Comments

@suryajak
Copy link
Contributor

Description

A few unit tests are broken in the logs microservice (referenced in this forked repo: suryajak@6b5afc0) which will need to be fixed once this is merged to master.

Steps to Reproduce

  1. Uncomment the tests in the referenced commit and run the unit tests

Expected behavior: [What you expect to happen]
Tests should pass

Actual behavior: [What actually happens]
Tests fail

Reproduces how often: [What percentage of the time does it reproduce?]
100%

@davidsims9t
Copy link

I created a PR for this issue: suryajak#2

@suryajak
Copy link
Contributor Author

@davidsims9t
Copy link

@suryajak Yes I opened a PR against this repo. Also I noticed you didn't mention the test on lines 303 to 334. Should I ignore this test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants