Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] optimise doc #145

Open
rbalet opened this issue Jul 24, 2024 · 0 comments
Open

[Feature] optimise doc #145

rbalet opened this issue Jul 24, 2024 · 0 comments

Comments

@rbalet
Copy link

rbalet commented Jul 24, 2024

Is your feature request related to a problem? Please describe

If you initialise the NgcCookieConsentService in the AppComponent, then you subscribe to it there, you will never get a ngOnDestroy() therefore, it will kind of create this memory leak that the doc talk about

Describe the idea you'd like

As the cookie banner could be answered only once, we could user pipe(take(1)) instead.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant