Add hypercore chunk tests for triggers #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
hypercore-test-triggers
branch
from
1a7f4b1
to
1510ded
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7483 +/- ##
==========================================
+ Coverage 80.06% 82.18% +2.11%
==========================================
Files 190 230 +40
Lines 37181 43188 +6007
Branches 9450 10867 +1417
==========================================
+ Hits 29770 35495 +5725
- Misses 2997 3371 +374
+ Partials 4414 4322 -92 ☔ View full report in Codecov by Sentry. |
|
@gayyappan, @erimatnor: please review this pull request.
|
mkindahl
force-pushed
the
hypercore-test-triggers
branch
from
1510ded
to
22e974d
Compare
erimatnor
approved these changes
Nov 27, 2024
mkindahl
force-pushed
the
hypercore-test-triggers
branch
from
22e974d
to
7c4a55b
Compare
fabriziomello
approved these changes
Nov 28, 2024
mkindahl
force-pushed
the
hypercore-test-triggers
branch
4 times, most recently
from
12be248
to
e727459
Compare
Add tests for statement and row triggers on hypercore chunks. We test `INSERT`, `UPDATE`, `DELETE`, and `TRUNCATE` triggers, where applicable. We check that the `OLD` and `NEW` values are correct as well as that the statement and row triggers are executed the correct number of times.
mkindahl
force-pushed
the
hypercore-test-triggers
branch
from
e727459
to
17d35ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for statement and row triggers on hypercore chunks. We test
INSERT,UPDATE,DELETE, andTRUNCATEtriggers, where applicable. We check that theOLDandNEWvalues are correct as well as that the statement and row triggers are executed the correct number of times.Disable-check: force-changelog-file