Allow hypertable constraint creation USING INDEX #7040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
2 times, most recently
from
32859da
to
5878a37
Compare
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
2 times, most recently
from
5e03859
to
9c82c96
Compare
|
Hmm ideally we remove the pg constraint tracking from chunk_constraint then we wouldnt need to do anything special for constraint creation with index. |
svenklemm
requested changes
Jun 19, 2024
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
3 times, most recently
from
99090d7
to
aa519a8
Compare
|
A lot of tests are failing. |
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
8 times, most recently
from
5d11129
to
346d57d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7040 +/- ##
==========================================
+ Coverage 80.06% 81.78% +1.71%
==========================================
Files 190 204 +14
Lines 37181 38144 +963
Branches 9450 9892 +442
==========================================
+ Hits 29770 31197 +1427
+ Misses 2997 2964 -33
+ Partials 4414 3983 -431 ☔ View full report in Codecov by Sentry. |
| @@ -2020,7 +2021,7 @@ process_rename_index(ProcessUtilityArgs *args, Cache *hcache, Oid relid, RenameS | |||
| Chunk *chunk = ts_chunk_get_by_relid(tablerelid, false); | |||
|
|
|||
| if (NULL != chunk) | |||
| ts_chunk_index_rename(chunk, relid, stmt->newname); | |||
| ts_chunk_index_rename(chunk, indexname, stmt->newname); | |||
There was a problem hiding this comment.
curious why we don't have coverage for this code path
There was a problem hiding this comment.
@fabriziomello , IIUC, this is not a problem with this PR? should we address it separately?
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
from
346d57d
to
26d40f0
Compare
Before this commit, the following operation was disallowed: ```sql ALTER TABLE foo ADD CONSTRAINT foo_pkey PRIMARY KEY USING INDEX foo_pkey ``` pgcopydb, the tool that powers our migration process[1], handles primary key and unique constraint migrations in two steps: 1. Build unique indexes. 2. Create the unique constraint or primary key using the unique index created in step 1. This multi-step approach is useful for reducing the time spent on EXCLUSIVE LOCKS while building unique constraints or primary keys. [1] https://docs.timescale.com/migrate/latest/live-migration/ Signed-off-by: Arunprasad Rajkumar <[email protected]>
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
2 times, most recently
from
1546932
to
ad5ef73
Compare
arajkumar
force-pushed
the
arajkumar/constraint-using-index
branch
from
ad5ef73
to
1546932
Compare
|
@fabriziomello Thanks for reviewing this PR. I've addressed your concerns, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the following operation was disallowed:
pgcopydb, the tool that powers our migration process[1], handles primary key
and unique constraint migrations in two steps:
in step 1.
This multi-step approach is useful for reducing the time spent on
EXCLUSIVE LOCKS while building unique constraints or primary keys.
[1] https://docs.timescale.com/migrate/latest/live-migration/
Fixes DAT-36
https://linear.app/timescale/issue/DAT-36