Fix segfault creating CAgg on hypertable by hash #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6981 +/- ##
==========================================
+ Coverage 80.06% 81.74% +1.68%
==========================================
Files 190 199 +9
Lines 37181 37015 -166
Branches 9450 9673 +223
==========================================
+ Hits 29770 30259 +489
+ Misses 2997 2862 -135
+ Partials 4414 3894 -520 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
fix_segfault_create_cagg_on_hypertable_by_hash
branch
from
d917a6f
to
561f428
Compare
fabriziomello
force-pushed
the
fix_segfault_create_cagg_on_hypertable_by_hash
branch
from
561f428
to
38e294f
Compare
nikkhils
reviewed
Jun 5, 2024
tsl/test/expected/cagg_ddl-14.out
Outdated
| @@ -2116,3 +2116,20 @@ SELECT * FROM _timescaledb_catalog.compression_settings; | |||
| -------+-----------+---------+--------------+-------------------- | |||
| (0 rows) | |||
|
|
|||
| -- hash partitioning test | |||
| CREATE TABLE test_by_hash (id BIGINT, value FLOAT8); | |||
| SELECT create_hypertable('test_by_hash', by_hash('id', 8)); | |||
There was a problem hiding this comment.
@fabriziomello with my PR #6993 we won't allow creation of hypertables with by_hash
The new hypertable API allows create it with primary space partition and CAggs doesn't support hypertables with custom partition functions. Fixed the segfault by properly checking if there are an open dimension available during the validation.
fabriziomello
force-pushed
the
fix_segfault_create_cagg_on_hypertable_by_hash
branch
from
38e294f
to
a5d846c
Compare
svenklemm
approved these changes
Jun 5, 2024
antekresic
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new hypertable API allows create it with primary space partition and CAggs doesn't support hypertables with custom partition functions.
Fixed the segfault by properly checking if there are an open dimension available during the validation.
Disable-check: force-changelog-file