Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn about Kebechet managers used in specific repos #1181

Closed
pacospace opened this issue Jan 13, 2021 · 21 comments
Closed

Learn about Kebechet managers used in specific repos #1181

pacospace opened this issue Jan 13, 2021 · 21 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/observability Categorizes an issue or PR as relevant to SIG Observability

Comments

@pacospace
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, we know when a user is installing Kebechet and if it is active or not, so that we can provide services accordingly.

But we don't have a way to store information about which managers are active. Moreover, if the user deactivates a certain manager would be also interesting to know.

@pacospace
Copy link
Contributor Author

Related-to: thoth-station/metrics-exporter#559
Related-to: thoth-station/kebechet#546

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Jan 28, 2021
@sesheta
Copy link
Member

sesheta commented Apr 28, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2021
@pacospace
Copy link
Contributor Author

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2021
@goern
Copy link
Member

goern commented May 1, 2021

/triage needs-information
/sig observability

@sesheta sesheta added triage/needs-information Indicates an issue needs more information in order to work on it. sig/observability Categorizes an issue or PR as relevant to SIG Observability labels May 1, 2021
@harshad16 harshad16 removed the triage/needs-information Indicates an issue needs more information in order to work on it. label May 12, 2021
@goern goern added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jun 10, 2021
@sesheta
Copy link
Member

sesheta commented Jul 15, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 15, 2021
@sesheta
Copy link
Member

sesheta commented Aug 24, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Aug 24, 2021
@sesheta
Copy link
Member

sesheta commented Aug 24, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Aug 24, 2021
@pacospace
Copy link
Contributor Author

@KPostOffice is this something we can do already?

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta closed this as completed Sep 23, 2021
@sesheta
Copy link
Member

sesheta commented Sep 23, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Sep 27, 2021
@KPostOffice
Copy link
Member

@pacospace This is actually present in storages. We store each manager as a boolean column for the installation. Here is a query which uses it. https://github.com/thoth-station/storages/blob/6cf9c2c05d02c698bb8ad8641146cd1dab582fe6/thoth/storages/graph/postgres.py#L3890
We want to get a count of how many instances of each manager we find in the database right?

@pacospace
Copy link
Contributor Author

@pacospace This is actually present in storages. We store each manager as a boolean column for the installation. Here is a query which uses it. https://github.com/thoth-station/storages/blob/6cf9c2c05d02c698bb8ad8641146cd1dab582fe6/thoth/storages/graph/postgres.py#L3890 We want to get a count of how many instances of each manager we find in the database right?

should we add a distinct in that query? because a slug can have multiple runtime environments right?

@KPostOffice
Copy link
Member

https://github.com/thoth-station/storages/blob/6cf9c2c05d02c698bb8ad8641146cd1dab582fe6/thoth/storages/graph/postgres.py#L3917

We grab just the first

@pacospace
Copy link
Contributor Author

@pacospace
Copy link
Contributor Author

@pacospace This is actually present in storages. We store each manager as a boolean column for the installation. Here is a query which uses it. https://github.com/thoth-station/storages/blob/6cf9c2c05d02c698bb8ad8641146cd1dab582fe6/thoth/storages/graph/postgres.py#L3890 We want to get a count of how many instances of each manager we find in the database right?

Yes, don't we have a query for that?

@KPostOffice
Copy link
Member

@pacospace This is actually present in storages. We store each manager as a boolean column for the installation. Here is a query which uses it. https://github.com/thoth-station/storages/blob/6cf9c2c05d02c698bb8ad8641146cd1dab582fe6/thoth/storages/graph/postgres.py#L3890 We want to get a count of how many instances of each manager we find in the database right?

Yes, don't we have a query for that?

Yeah you are right. It is right here

@pacospace
Copy link
Contributor Author

@pacospace This is actually present in storages. We store each manager as a boolean column for the installation. Here is a query which uses it. https://github.com/thoth-station/storages/blob/6cf9c2c05d02c698bb8ad8641146cd1dab582fe6/thoth/storages/graph/postgres.py#L3890 We want to get a count of how many instances of each manager we find in the database right?

Yes, don't we have a query for that?

Yeah you are right. It is right here

Then I think we can close this issue right?

@goern
Copy link
Member

goern commented Oct 4, 2021

/close

@sesheta
Copy link
Member

sesheta commented Oct 4, 2021

@goern: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/observability Categorizes an issue or PR as relevant to SIG Observability
Projects
None yet
Development

No branches or pull requests

7 participants