Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to a maintained through? #249

Open
ljharb opened this issue Jul 18, 2023 · 3 comments · May be fixed by #250
Open

update to a maintained through? #249

ljharb opened this issue Jul 18, 2023 · 3 comments · May be fixed by #250

Comments

@ljharb
Copy link

ljharb commented Jul 18, 2023 •
edited
Loading

Hi! You depend on through, an excellent package that unfortunately has not been maintained since 2018. I've forked it as https://npmjs.com/@ljharb/through so that I can maintain it (with @dominictarr's blessing), and am using it in https://npmjs.com/tape.

Would you be interested in a PR that switches this project to using my fork instead of the original? It's effectively identical, but it'd ensure any vulnerabilities will be addressed in the future.
@bendrucker
Copy link
Collaborator

switches inquirer

Assuming this is a copy paste error? But sure this sounds fine happy to merge.

@ljharb
Copy link
Author

ljharb commented Jul 18, 2023

lol oops, yes, copy-paste error. thanks, i'll make a PR!

ljharb added a commit to ljharb/browserify-shim that referenced this issue Jul 18, 2023
@ljharb
[Deps] switch through to @ljharb/through
4045d4f 
Closes thlorenz#249
@ljharb ljharb linked a pull request Jul 18, 2023 that will close this issue
Open
@valadaptive
Copy link

Just to clarify: the codebases are (as far as I can tell) effectively identical at this time, except for the fact that through has 0 dependencies whereas @ljharb/through has 12 nested dependencies for the purpose of Node 0.4 support. You can decide for yourself whether the extra dependencies are worth the Node 0.4 support, but I think it is important to be transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Deps] switch through to @ljharb/through ljharb/browserify-shim
3 participants
@ljharb @bendrucker @valadaptive