Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to projectd_65_ansi keyboard #1983

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Add support to projectd_65_ansi keyboard #1983

merged 4 commits into from
Aug 26, 2023

Conversation

gskygithub
Copy link
Contributor

Description

Add projectd_65_ansi keyboard

QMK Pull Request

qmk/qmk_firmware#21520

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.caniusevia.com/docs/layouts#kle-json-rules

Please colour in your JSON keys

v3/projectd/ansi/65/projectd_65_ansi.json Outdated Show resolved Hide resolved
@gskygithub
Copy link
Contributor Author

@Xelus22 Resolved requested changes, thanks.

@Xelus22 Xelus22 merged commit 7e98405 into the-via:master Aug 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gskygithub @Xelus22