Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added support for phoenix_project_no1 #1982

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

mymakercorner
Copy link
Contributor

@mymakercorner mymakercorner commented Aug 13, 2023

Add support for the phoenix_project_no1 PCB

QMK PR #21068

Description

QMK Pull Request

QMK PR #21068

qmk/qmk_firmware#21068

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@mymakercorner
Copy link
Contributor Author

Dear maintainers,

Please tell me if you need any additional information or modifications to be done on my side so that this pull request can move forward.

Best Regards,

Rico

@Xelus22 Xelus22 merged commit aded110 into the-via:master Aug 19, 2023
2 checks passed
@Xelus22
Copy link
Collaborator

Xelus22 commented Aug 19, 2023

Hi there, I check once a week on the weekend (most of the time). Thanks for the submission

@mymakercorner
Copy link
Contributor Author

Hello Xelus,

Wow that was fast !

Thank you very much for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants