Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CXT Studio #1981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for CXT Studio #1981

wants to merge 1 commit into from

Conversation

puffnfresh
Copy link

Description

QMK Pull Request

qmk/qmk_firmware#21675

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Aug 13, 2023
View reviewed changes
src/cxt/studio.json Outdated Show resolved Hide resolved
Xelus22
Xelus22 requested changes Aug 13, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"keycodes": [ "qmk_lighting" ]

you'll likely want this too in here.

also move your definition from the src/ folder to v3/

@puffnfresh
Copy link
Author

@Xelus22 I've updated the PR, thanks for catching those issues.

Xelus22
Xelus22 requested changes Sep 11, 2023
View reviewed changes
v3/cxt/studio.json
"vendorId": "0xC401",
"productId": "0x5754",
"keycodes": ["qmk_lighting"],
"menus": ["qmk_rgb_matrix"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like in QMK not all effect are enabled. Please align QMK with VIA or VIA with QMK source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puffnfresh @Xelus22