Fix "current" week calculation outside the regular season #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EventWeekTab now represents a range of weeks so we can find the right one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our previous "current" week calculation doesn't really work outside the regular season because we are comparing the current week number of the year to tabs that represent an entire month.
For example, if the season ends on "week 7" (let's ignore pre-season for the sake of this example), then the following month is "week 8" and two months later is "week 9". But going by the calendar, we are on like week 20 by that point.
Instead, our
EventWeekTabnow represents a range of actual calendar weeks so we can find the correct tab for the current week.Issues Reference:
Fixes #981
Test Plan:
New unit tests!
Also confirmed November is now correctly selected by default instead of December ✅