Fix team event navigation sometimes loading the wrong event data #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Navigating to a Team at Event page from the team event list would sometimes load data from the incorrect event.
This occured due to a combinatino of two things:
updateEventsParticipated()
getting called multiple times with different event lists.Issues Reference:
Fixes #973
Fixes #964
Test Plan:
Repro steps in #973 mostly worked for me; note that there's some odd cache behavior happening here that needs to happen. When I observed this occurring we had database-cached responses that had a different set of events for the team than the API provided. The reproduction steps weren't 100% consistent, but consistent enough.
In theory this should self-resolve, but the API responses were coming from our HTTP cache and we explicitly don't write to the DB cache if the API response is coming from the HTTP cache. There's a lot to unpack there still.