Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications don't handle playoff tiebreaker criteria properly #926

Open
lethosor opened this issue Oct 1, 2019 · 0 comments
Open

Notifications don't handle playoff tiebreaker criteria properly #926

lethosor opened this issue Oct 1, 2019 · 0 comments

Comments

@lethosor
Copy link

lethosor commented Oct 1, 2019

A playoff match where the overall score was tied will display "teams A-B-C tied D-E-F scoring X-X" in the notification, even in cases when the tie was broken. (Since #734, this is displayed correctly in the app when selecting the notification.)

I suspect this is the cause (but I don't have a dev environment set up to test it). The winning_alliance field from the API should be correct (example).

} else if (blueScore == redScore) { // firstTeams tied secondTeams
template = context.getString(R.string.notification_score_teams_tied_teams);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant