Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think what is happening here is we're working around a bug in rnmapbox where they ignore the
scale
attribute of RNImageSource
s passed into theMapbox.Images
component on Android only. We do this by selectively multiplying the icon size by the pixel ratio on Android only. I'd like paul to confirm it looks good on his iOS dev setup before merging, but i think we still won't know until we push a release with this fix.Checklist
Related Issues
Fixes (hopefully, once QA'd) #192, #367, #316, and #365
Verification steps
Map icons should be the correct size and not pixelated on all platforms.