Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map icon size and resolution #387

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Aug 31, 2023

Description

I think what is happening here is we're working around a bug in rnmapbox where they ignore the scale attribute of RN ImageSources passed into the Mapbox.Images component on Android only. We do this by selectively multiplying the icon size by the pixel ratio on Android only. I'd like paul to confirm it looks good on his iOS dev setup before merging, but i think we still won't know until we push a release with this fix.

Checklist

  • Corresponding issue has been opened

Related Issues

Fixes (hopefully, once QA'd) #192, #367, #316, and #365

Verification steps

Map icons should be the correct size and not pixelated on all platforms.

@shrouxm
Copy link
Member Author

shrouxm commented Aug 31, 2023

@paulschreiber there are two commits on the branch. the head commit i think should be working properly, but if it isn't try the other commit and make that one the head commit if it works better!

@paulschreiber paulschreiber merged commit 1d1cc51 into main Aug 31, 2023
4 checks passed
@paulschreiber paulschreiber deleted the fix/map-icon-size-and-resolution branch August 31, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants