Fix issue #115 #116
Fix issue #115 #116
Conversation
|
|
||
| ```bash | ||
| $ pacman -Suy | ||
| $ pacman -S git mingw-w64-ucrt-x86_64-meson mingw-w64-ucrt-x86_64-gtk4 mingw-w64-ucrt-x86_64-python3 mingw-w64-ucrt-x86_64-python3-gobject mingw-w64-ucrt-x86_64-libadwaita mingw-w64-ucrt-x86_64-gstreamer mingw-w64-ucrt-x86_64-gst-plugins-good mingw-w64-ucrt-x86_64-gtksourceview5 mingw-w64-ucrt-x86_64-librsvg mingw-w64-ucrt-x86_64-desktop-file-utils | ||
| $ pacman -S git mingw-w64-ucrt-x86_64-meson mingw-w64-ucrt-x86_64-gtk4 mingw-w64-ucrt-x86_64-python3 mingw-w64-ucrt-x86_64-python3-gobject mingw-w64-ucrt-x86_64-libadwaita mingw-w64-ucrt-x86_64-gstreamer mingw-w64-ucrt-x86_64-gst-plugins-good mingw-w64-ucrt-x86_64-gtksourceview5 mingw-w64-ucrt-x86_64-librsvg mingw-w64-ucrt-x86_64-desktop-file-utils unzip meson cmake |
There was a problem hiding this comment.
Note that meson is already in this list (as mingw-w64-ucrt-x86_64-meson). As per cmake, it's not needed here, since we're not building anything else manually that requires cmake.
There was a problem hiding this comment.
Even so, the unzip package is necessary for the subsequent steps.
There was a problem hiding this comment.
Unzip is fine, the other aren't necessary.
There was a problem hiding this comment.
A recent change we merged made pandoc not needed anymore to build Gameeky, can you update accordingly?
There was a problem hiding this comment.
@Tom5521 any chance to get this done ? :)
| $ mkdir -p /usr/share/gettext/its # Create the directory if it does not exist | ||
| $ cp /ucrt64/share/gettext/its/* /usr/share/gettext/its -rf # and copy the files | ||
| ``` | ||
| #### Note: in windows you have to disable the webkit by using `meson setup build -Dwebkit=disabled` |
There was a problem hiding this comment.
To speed this up for less technical users, let's also include the complete build steps, e.g., git clone, meson setup, ninja install, etc.
|
|
||
| Lastly, make sure to copy gettext ITS files from `msys2/ucrt64/share/gettext/its` to `msys2/usr/share/gettext/its`. | ||
|
|
There was a problem hiding this comment.
Lastly, something to take into account when you're contributing to a project is to "inspect" how things are organized, e.g., commit messages, directories structure, file naming, coding style, etc. The closer you follow these things the better.
In this particular case, you can run git log CONTRIBUTING.md and you will see how I organize commits, you can modify your commit message with git commit --amend.
For this change, a single commit is enough, and you can squash the commits using git rebase --interactive. This is something very useful to learn.
You should still add Fixes #115 under the commit title (again, check the git log for examples).
No description provided.