Skip to content

Latest commit

 

History

History
148 lines (102 loc) · 8.08 KB

CONTRIBUTING.md

File metadata and controls

148 lines (102 loc) · 8.08 KB
Raw

Contribution Guidance

If you'd like to contribute to this repository, please read the following guidelines. Contributors are more than welcome to share your learnings with others from centralized location.

Code of Conduct

This project has adopted the Microsoft Open Source Code of Conduct. For more information, see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Question or Problem?

Please do not open GitHub issues for general support questions as the GitHub list should be used for feature requests and bug reports. This way we can more easily track actual issues or bugs from the code and keep the general discussion separate from the actual code.

If you have questions about how to use SharePoint Framework or any of the provided samples, please use the following locations.

Typos, Issues, Bugs and contributions

Whenever you are submitting any changes to the SharePoint repositories, please follow these recommendations.

  • Always fork repository to your own account for applying modifications
  • Do not combine multiple changes to one pull request, please submit for example any samples and documentation updates using separate PRs
  • If you are submitting multiple samples, please create specific PR for each of them
  • If you are submitting typo or documentation fix, you can combine modifications to single PR where suitable

Sample Naming and Structure Guidelines

When you are submitting a new sample, it has to follow up below guidelines

  • You will need to have a README file for your contribution, which is based on provided template under the Samples folder. Please copy this template and update accordingly. README has to be named as README.md with capital letters.
    • You will need to have a picture of the web part in practice in the README file ("pics or it didn't happen"). Preview image must be located in /assets/ folder in the root your you solution.
  • README template contains specific tracking image as a final entry in the page with img tag by default to https://telemetry.sharepointpnp.com/sp-dev-fx-webparts/samples/readme-template. This is transparent image, which is used to track popularity of individual samples in GitHub.
  • If you find already similar kind of sample from the existing samples, we would appreciate you to rather extend existing one, than submitting a new similar sample
    • If you for example use Office Graph with React, please rather add new web part to already existing solution, rather than introducing completely new solution
    • When you update existing samples, please update also README accordingly with information on provided changes and with your author details
  • When you are submitting new sample solution, please name the sample solution folder accordingly
    • Folder should start by identifying JS library used - like "react-", "angular-", "knockout-"
    • If you are not using any specific JS library, please use "js-" as the prefix for your sample
    • Do not use words "sample", "webpart" or "wb" in the folder or sample name - these are samples for client-side web parts repository
    • If your solution is demonstrating multiple technologies, please use functional terms as the name for the solution folder
  • Do not use period/dot in the folder name of the provided sample

Submitting Pull Requests

Here's a high level process for submitting new samples or updates to existing ones.

  1. Sign the Contributor License Agreement (see below)
  2. Fork this repository SharePoint/sp-dev-fx-webparts to your GitHub account
  3. Create a new branch off the master branch for your fork for the contribution
  4. Include your changes to your branch
  5. Commit your changes using descriptive commit message * These are used to track changes on the repositories for monthly communications
  6. Create a pull request in your own fork and target dev branch
  7. Fill up the provided PR template with the requested details

Before you submit your pull request consider the following guidelines:

  • Search GitHub for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.

  • Make sure you have a link in your local cloned fork to the SharePoint/sp-dev-fx-webparts:

    # check if you have a remote pointing to the Microsoft repo:
git remote -v

# if you see a pair of remotes (fetch & pull) that point to https://github.com/SharePoint/sp-dev-fx-webparts, you're ok... otherwise you need to add one

# add a new remote named "upstream" and point to the Microsoft repo
git remote add upstream https://github.com/SharePoint/sp-dev-fx-webparts.git

  • Make your changes in a new git branch:

    git checkout -b react-taxonomypicker master

  • Ensure your fork is updated and not behind the upstream sp-dev-fx-webparts repo. Refer to these resources for more information on syncing your repo:

    • GitHub Help: Syncing a Fork

    • Keep Your Forked Git Repo Updated with Changes from the Original Upstream Repo

    • For a quick cheat sheet:

      # assuming you are in the folder of your locally cloned fork....
git checkout master

# assuming you have a remote named `upstream` pointing official **sp-dev-fx-webparts** repo
git fetch upstream

# update your local master to be a mirror of what's in the main repo
git pull --rebase upstream master

# switch to your branch where you are working, say "react-taxonomypicker"
git checkout react-taxonomypicker

# update your branch to update it's fork point to the current tip of master & put your changes on top of it
git rebase master

  • Push your branch to GitHub:

    git push origin react-taxonomypicker

Merging your Existing Github Projects with this Repository

If the sample you wish to contribute is stored in your own Github repository, you can use the following steps to merge it with the this repository:

  • Fork the sp-dev-fx-webparts repository from GitHub

  • Create a local git repository

    md sp-dev-fx-webparts
cd sp-dev-fx-webparts
git init

  • Pull your forked copy of sp-dev-fx-webparts into your local repository

    git remote add origin https://github.com/yourgitaccount/sp-dev-fx-webparts.git
git pull origin dev

  • Pull your other project from github into the samples folder of your local copy of sp-dev-fx-webparts

    git subtree add --prefix=samples/projectname https://github.com/yourgitaccount/projectname.git master

  • Push the changes up to your forked repository

    git push origin dev

Signing the CLA

Before we can accept your pull requests you will be asked to sign electronically Contributor License Agreement (CLA), which is prerequisite for any contributions to PnP repository. This will be one time process, so for any future contributions you will not be asked to re-sign anything. After the CLA has been signed, our PnP core team members will have a look on your submission for final verification of the submission. Please do not delete your development branch until the submission has been closed.

You can find Microsoft CLA from the following address - https://cla.microsoft.com.

Thank you for your contribution.

Sharing is caring.