Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for stack traces produced by --enable-source-maps #59

Open
coreyfarrell opened this issue Feb 19, 2021 · 1 comment
Open

Add tests for stack traces produced by --enable-source-maps #59

coreyfarrell opened this issue Feb 19, 2021 · 1 comment

Comments

@coreyfarrell
Copy link
Member

coreyfarrell commented Feb 19, 2021

Newer versions of node.js have built-in support for processing source-maps. We should test against some stack traces produced by --enable-source-maps.

Edit: I've been experimenting with --enable-source-maps and everything seems to work correctly though I think I'm likely only hitting nominal conditions.

@conartist6
Copy link

Any update on whether there's action needed on this? It sounds like you're saying that the stack trace format is unchanged with sourcemaps just providing different file names and line numbers, which is what I would expect. If there is further action needed, I'd really appreciate it if you would open an issue against stack-tools!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants