-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overridable class strategy #162
Comments
Can you give a concrete example of something that doesn't work? Are you trying to override the form styles with custom styles that you are putting in the base layer? |
Yep, that's pretty much it.
It needs to be at the base layer because, well, it is the base style. |
Those classes are in the components layer so why not use |
I guess that's work, too; apology for the fuss. Nevertheless, all strategies at the base layer have advantages in some aspects. Their consistency makes the overriding layer agnostic to the strategies used. This makes it easier to share snippets in certain situations. That said, the advantage is likely marginal; thanks for the swift replies. |
Can you verify/check if this is the case in v4? as for me, they end up in the utilities layer. which makes changing the styles and allowing overrides not work. |
What version of @tailwindcss/forms are you using?
v0.5.7
Describe your issue
I read the discussion #22. The thread has been closed by adding
class
strategy.Sorry to bring this up again
However, the
class
strategy is not easily overridable because it was placed later in the CSS file (at the components layer).No matter the strategy used,
tailwindcss-forms
should always be a base, ready to be overridden by other stylings.Why the need for overrides?
I can't talk for others, as you'll see some of them on the discussion links above, but for me,
tailwindcss-forms
adds colors that almost always need overriding because they stand out like sore thumbs.What should we do?
Can we move CSS declarations of
class
strategy fromcomponents
layer tobase
layer?Basically, modify the code here:
tailwindcss-forms/src/index.js
Line 353 in c9d9da3
from
addComponents
toaddBase
.Why do I, or other similar people, use
tailwindcss-forms
at all?tailwindcss
has its ecosystem, and some 3rd-party components expecttailwindcss-forms
to be there as the base. We still want to work withtailwindcss-forms
and the people creating those components, even if we are not a fan of the approaches.The text was updated successfully, but these errors were encountered: