Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for keepalive do not match with the documentation #4751

Open
muhammetbudak opened this issue Nov 15, 2024 · 0 comments
Open

Comments

@muhammetbudak
Copy link

Hi team;

This is not a bug. I could not find a submit button on documentation page.
If this is a wrong place for this issue, you can close the ticket and redirect me to the correct place.

We are currently running 2.5.5 and we are planning to upgrade proxysql to 2.7.
I've started to check variables and seen some discrepancies between documentation and actual state in proxysql admin.

mysql-use_tcp_keepalive is false and mysql-tcp_keepalive_time is 0 by default according to the documentation.
In 2.5 the picture is really like this. We did not update these variables and we are using default values.

MySQL [(none)]> select @@version; select variable_name, variable_value from runtime_global_variables where variable_name in ('mysql-tcp_keepalive_time','mysql-use_tcp_keepalive');
+-------------------+
| @@version         |
+-------------------+
| 2.5.5-10-g195bd70 |
+-------------------+
1 row in set (0.002 sec)

+--------------------------+----------------+
| variable_name            | variable_value |
+--------------------------+----------------+
| mysql-tcp_keepalive_time | 0              |
| mysql-use_tcp_keepalive  | false          |
+--------------------------+----------------+
2 rows in set (0.004 sec)

I launched another proxysql instance with the same configuration but version 2.7.1.

MySQL [(none)]> select @@version; select variable_name, variable_value from runtime_global_variables where variable_name in ('mysql-tcp_keepalive_time','mysql-use_tcp_keepalive');
+-------------------+
| @@version         |
+-------------------+
| 2.7.1-16-g2726c27 |
+-------------------+
1 row in set (0.001 sec)

+--------------------------+----------------+
| variable_name            | variable_value |
+--------------------------+----------------+
| mysql-tcp_keepalive_time | 120            |
| mysql-use_tcp_keepalive  | true           |
+--------------------------+----------------+
2 rows in set (0.003 sec)

It seems default values have been changed. Both two proxysql instances do not have any user or server configuration.
Can you update the documentation?

https://proxysql.com/Documentation/global-variables/mysql-variables/#mysql-tcp_keepalive_time
https://proxysql.com/Documentation/global-variables/mysql-variables/#mysql-use_tcp_keepalive

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant