-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should Section "Approaches for moving followers and following" refer to the FEP with a test spec? #31
Comments
The LOLA spec already refers to FEP 7628 in section 7.2.1, which is normative.
The "Approaches for moving followers and following" section is part of the explanation preparing users with the overall picture to understand all the normative pieces. With this as background, what's the goal in referring to FEP 0f2a? It actually suggests a slightly different way of notifying followers of a moved actor, via an Announce- whereas LOLA and FEP 7628 suggest using a Move. I can schedule a discussion at any rate, flagging this personally for the next discussion. |
Hey! So, a few thing:
Honestly, the intention of 0f2a was just to elaborate the behavior of 7628 more explicitly and make it more testable. The test-cases were unaffected by the Move/Announce debate, since they test the actors themselves, not the S2S messages, but you'll notice that in the in-FEP issue tracker there's still a to-do to add example Move and Announce messages 😅
Short answer: yeah, no, Move makes more sense. Long answer: I think I got a little carried away reading this SocialHub thread about Announces versus bare activities and overthought it. After stewing on it a bit, backwards compatibility is more important than consistency. |
Thanks @bumblefudge that looks good to me (I don't have a codeberg account to give it a thumbs up there but consider it reviewed if that helps). clears up the confusion! |
The confusion was entirely in my own head, I was so fixated on the end-state (what you get when you query the Actor) that I forgot the S2S messaging is what most FEPs are actually about in the first place 😅 |
We wrote this up as a testable migration proposal over on the FEPs repo - should we consider aligning the section "Approaches for moving followers and following" with it, or mentioning it as one possible way of doing things there? It feels like a big discussion, so probably best scheduled in advance and give people an email heads up to read it if they have opinions...
The text was updated successfully, but these errors were encountered: