Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow injectable request sessions #485

Open
8W9aG opened this issue Dec 3, 2024 · 2 comments
Open

[Feature]: Allow injectable request sessions #485

8W9aG opened this issue Dec 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@8W9aG
Copy link

8W9aG commented Dec 3, 2024

NBA API Version

1.6.1

Issue

I currently use requests_cache and requests_retry to compose a requests.Session that aggressively caches and can retry lots of requests. I have used libraries like openmeteo_requests that allow this kind of pattern, and it would be great if nba_api could accept custom sessions in the same way.

I am more than willing to do this work just want to make sure the maintainers of this repo like the idea before proceeding.

Code

No response

@8W9aG 8W9aG added bug Something isn't working triage Researching into a possible bug labels Dec 3, 2024
@rsforbes
Copy link
Collaborator

rsforbes commented Dec 3, 2024

@8W9aG - Always happy to discuss contributions, and this sounds like a great option to enhance the library's capabilities. You can open a draft PR for discussion, or we can continue on this thread. Looking forward to hearing more on your proposal.

@rsforbes rsforbes added enhancement New feature or request and removed bug Something isn't working triage Researching into a possible bug labels Dec 3, 2024
@8W9aG
Copy link
Author

8W9aG commented Dec 3, 2024

Thanks! I have opened a draft PR here: #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants