Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: LeagueGameFinder endpoint not filtering for game_id #446

Open
RiccardoBarbieri opened this issue Jun 7, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@RiccardoBarbieri
Copy link

RiccardoBarbieri commented Jun 7, 2024

NBA API Version

1.4.1

Issue

When I make a request to leaguegamefinder specifying also a valid game_id_nullable the resulting response contains records that have games that do not match the provided game id.

Code

game_found = leaguegamefinder.LeagueGameFinder(
    player_or_team_abbreviation="T",
    league_id_nullable="00",
    game_id_nullable="0022301181"
)
@RiccardoBarbieri RiccardoBarbieri added bug Something isn't working triage Researching into a possible bug labels Jun 7, 2024
@rsforbes
Copy link
Collaborator

rsforbes commented Jun 8, 2024

@RiccardoBarbieri - Will get this look at this weekend.

@rsforbes rsforbes removed the triage Researching into a possible bug label Oct 23, 2024
@rsforbes
Copy link
Collaborator

@RiccardoBarbieri - It appears that the NBA has deprecated several call parameters, such as GameID. The call itself works; however, in some cases params are ignored and in other they result in an error. I'll have to check the integration tests to see the extent of parameter testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants