Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface LegendColor, issues with cellFilter method, argument type is missing #95

Open
NmiDev opened this issue Apr 8, 2020 · 0 comments

Comments

@NmiDev
Copy link

NmiDev commented Apr 8, 2020

Hi Susie,

Thanks for your amazing job !

I did notice a type issue when trying to use cellFilter in legendColor. Looking at the interfaces, it seems to me that the cellFilter method miss one argument ?

types/d3-svg-legend.d.ts : line 12

export interface LegendColor {
    ...
    cellFilter(filter: () => boolean): LegendColor;
    ...
}

regarding the documentation : "This function is run as a filter function against the array of cells. If you have a function(d){ return true or false }, d has a .data and a .label property"

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant