Solving the problem of Missing flag handling in ColorMyWorld #1603 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llaske#1603
This is my first pull request to an open source project. I’ve made improvements to handle missing flags in ColorMyWorld, as detailed in issue llaske#1603. Also when i am running the sugarizer using source code i can not see any flags with the country name and also can not see the country flags on the internet version of the sugarizer but the video you have provided shows it, what i have done is while clicking on the "SAINT VINCENT AND THE GRINADINES" it shows the name correctly without showing the undefined part. Please review it and tell me if it is okay, i have also added a video.
Screen.Recording.2024-08-11.224145.mp4